Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link for contributors on forks #19

Closed
An-dz opened this issue Aug 8, 2020 · 5 comments
Closed

Broken link for contributors on forks #19

An-dz opened this issue Aug 8, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@An-dz
Copy link
Contributor

An-dz commented Aug 8, 2020

On forked repositories the contributors link is broken, the user name is duplicated on the URL. I guess the reason is because GitHub decided to not show contributors on forks so the script fails to obtain the number of contributors and fallback to showing a single contributor.

Here's a repo that is a fork:
https://github.com/rust-lang/rust-enhanced

Seeing on archive that's something the redesign changed as it used to show up:
https://web.archive.org/web/20200530174346/https://github.com/rust-lang/rust-enhanced

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Aug 8, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Kir-Antipov
Copy link
Owner

I guess the reason is because GitHub decided to not show contributors on forks so the script fails to obtain the number of contributors and fallback to showing a single contributor

Absolutely true! Will fix it soon

By the way, thank you so much for all your issues, they really help improve the script! :)

@Kir-Antipov Kir-Antipov self-assigned this Aug 9, 2020
@Kir-Antipov
Copy link
Owner

Okay, maybe this will take a couple of days. I want to refactor some things and restructure the repository a little bit first

@Kir-Antipov
Copy link
Owner

I'm sorry it took me so long. I had to deal with a couple of deadlines :)

This fix will be available in v2.1.5

@An-dz
Copy link
Contributor Author

An-dz commented Aug 31, 2020

No problem, it's not like I would die without that :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants