Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slimmer toolbars on repository page #33

Closed
MrNaif2018 opened this issue Apr 3, 2021 · 6 comments
Closed

Slimmer toolbars on repository page #33

MrNaif2018 opened this issue Apr 3, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@MrNaif2018
Copy link

Description

I am not 100% sure, but few updates back I have noticed that all toolbars (showing latest commit, issue filter, etc.) are now slimmer than before (looks like removed paddings). It was not so in the previous versions, and also not in the original github UI. Sorry if I missed some change, but I definitely remember it was not so before, see the screenshots below.

Screenshot

( Showing on my own repo, as I don't have any other screenshots from older versions of the script)

Current toolbars:

In the repo page:

изображение

In the issues filter:

изображение

Pull requests filter:

изображение

How was it back then:

At the initial versions of the script:

изображение

Few months after the creation of the script:

изображение

Other information

  • Link to page with the issue: Any repository page, for example, my repo
  • Web Archive example: Web archive seems to be unavailable now, see the screenshots above, will add an example when it's back up, but it's easy to find out
  • Browser: Firefox 86.0, tried in Chrome 89.0.4389.90, same issue
  • Operating System: Linux Mint 20.1 XFCE 64 bit
  • GitHub-Defreshed version: 4.2.1
@MrNaif2018 MrNaif2018 added the bug Something isn't working label Apr 3, 2021
@Kir-Antipov
Copy link
Owner

Kir-Antipov commented Apr 3, 2021

Not a bug, but a feature :)

Yep, toolbars definitely lost a few pixels, but it was intentional. At the moment, with the help of Microsoft, they have grown to insane proportions:

wtf

And I really don't know why these guys are so much into wasting space...

Web archive seems to be unavailable now, see the screenshots above, will add an example when it's back up, but it's easy to find out

Well, it's up now (at least for me), so I've just used the link you gave me earlier:

before

With GitHub-Defreshed:

now

So, yeah, it seems like I overdid slimming a little bit (38.3 < 43.6), but did I really? As for me, even "golden age" toolbar was kinda plumper than it should be. Anyway, as always, I'm open for suggestions, so I can make this thing optional :) Should I?

@MrNaif2018
Copy link
Author

Thank you for replying! Yeah, I checked the recent UI and it's now ridiculously wide. Not really an issue to me, just something I noticed and wanted to let you know (I am just used to old style visually).
I think it is fine, but if you add this option it would be great. Don't want to request some features which aren't very important and are very subjective.
I will close the issue, it's up to you whether to add this feature or not, this script is already helping lots of people!
Thank you very much.

@Kir-Antipov
Copy link
Owner

something I noticed and wanted to let you know

Thanks a lot! Sometimes it's really helpful as I don't always notice changes made by Microsoft :)

Don't want to request some features which aren't very important and are very subjective

Nothing to worry about: a lot of stuff about UI in general is "not very important" and "subjective", but all these small features form an interface we're comfortable with

it's up to you whether to add this feature or not

I think I'll ship it with a new version. Right now I have some things to do, so it will be a week or something like this

@Kir-Antipov Kir-Antipov reopened this Apr 3, 2021
@Kir-Antipov Kir-Antipov changed the title [BUG] Slimmer toolbars on repository page Slimmer toolbars on repository page Apr 3, 2021
@Kir-Antipov Kir-Antipov added enhancement New feature or request and removed bug Something isn't working labels Apr 3, 2021
@stale
Copy link

stale bot commented Apr 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 14, 2021
@MrNaif2018
Copy link
Author

Not stale (:

@stale stale bot removed the wontfix This will not be worked on label Apr 14, 2021
@Kir-Antipov
Copy link
Owner

Usually @stale closes posts, the authors of which have disappeared and stopped responding. In my case, it's a little bit different:

do something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants