Unable to command/ctrl click to open links in a new tab

[ccampbell]

Hi there, Thanks so much for all the work you put into this, it is impressive. One issue that I noticed is that when this is installed command click on links no longer opens them in a new tab.

It seems that some links work, but some do not. I am not sure the exact behavior causing it, but probably a preventDefault() somewhere where it should not be if (e.metaKey || e.ctrlKey) is pressed

Ah ya the problematic part looks to be:

GitHub-Defreshed/src/fixers/links-fixer.js

Lines 21 to 25 in e504656

	a.addEventListener("click", async function(e) {
	e.stopPropagation();
	e.preventDefault();
	navigate(getAbsoluteURL(this.href));
	});

Anchor links also don’t seem to work correctly

[Kir-Antipov]

Thanks so much for all the work you put into this, it is impressive

Really glad to here that :3

command click on links no longer opens them in a new tab

Whoops, didn't noticed that cause I'm using middle mouse button for these purposes (seems like its behavior can't be overridden).

Ah ya the problematic part looks to be [...]
if (e.metaKey || e.ctrlKey) [...]

Yeah, you're absolutely right. Will fix it in a minute

Anchor links also don’t seem to work correctly

Are you sure about that? 'Cause v1.2.0 fixed that

[Kir-Antipov]

Fixed in v1.3.0

Don't forget to force your userscript engine to update the script to get fix as fast as possible :)

[ccampbell]

Thanks for the quick turnaround, just updated and it is fixed. The anchor links are still broken for me though.

To test go to your own repo page:
https://github.com/Kir-Antipov/GitHub-Defreshed

Then hover over one of the headers and click on the anchor

It refreshes the page inline and does not link to the anchor

[Kir-Antipov]

@ccampbell, oh... Yeah... I fixed only "#" links, not "#something"... What a shame...

Moved it into new issue. Third (or even fourth) update for one day is coming xD

[Kir-Antipov]

@ccampbell, v1.3.5 is onboard, everything should be fine now :)

[ccampbell]

Awesome, just updated and looks good 👍 will open a new issue if I run into anything else. Thanks!

[Kir-Antipov]

You're welcome! :)