Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass res in the configuration object #49

Closed
ramiel opened this issue Sep 4, 2017 · 3 comments
Closed

Pass res in the configuration object #49

ramiel opened this issue Sep 4, 2017 · 3 comments

Comments

@ramiel
Copy link
Contributor

ramiel commented Sep 4, 2017

Is there any reason why res is not passed int he second parameter to the makeStore function? Is it possible to add it?

@kirill-konshin
Copy link
Owner

The idea was to keep the function signature as small as possible. Can you give me an example scenario when user would need a res inside of makeStore function?

@ramiel
Copy link
Contributor Author

ramiel commented Sep 5, 2017

While I create the store I subscribe to some events to redirect depending on some events. If I'm on the server I need to use res to set the redirection headers. While this is the main entry point for the redux store in the application I setup what I need starting from there.

@kirill-konshin
Copy link
Owner

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants