Skip to content

Commit

Permalink
feat: add ARIA attrs to whitelist symbol attributes
Browse files Browse the repository at this point in the history
Fixed: #304
  • Loading branch information
kisenka committed Sep 19, 2018
1 parent e7afbcf commit 4bbccab
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 16 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
"escape-string-regexp": "1.0.5",
"html-webpack-plugin": "^3.2.0",
"loader-utils": "^1.1.0",
"svg-baker": "^1.2.17",
"svg-baker": "^1.3.0",
"svg-baker-runtime": "^1.3.3",
"webpack": "^4.12.1",
"url-slug": "2.0.0"
"url-slug": "2.0.0",
"webpack": "^4.12.1"
},
"devDependencies": {
"babel-core": "^6.24.1",
Expand Down
12 changes: 0 additions & 12 deletions test/loader.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -397,18 +397,6 @@ describe('loader and plugin', () => {
assets.should.have.property('entry2-sprite.svg');
});

it('should allow to use [hash] substitution token in `spriteFilename`', async () => {
const { assets } = await compile({
entry: './entry',
module: rules(
svgRule({ extract: true, spriteFilename: '[sha1:hash:base36:10].svg' })
),
plugins: [new SpritePlugin()]
});

assets.should.have.property('lvn29bpor3.svg');
});

// Fails when webpack buildin runtime will change
it('should replace with proper publicPath', async () => {
const publicPath = '/olala/';
Expand Down
20 changes: 19 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7938,7 +7938,7 @@ svg-baker-runtime@^1.3.3:
mitt "1.1.2"
svg-baker "^1.2.0"

svg-baker@^1.2.0, svg-baker@^1.2.17:
svg-baker@^1.2.0:
version "1.2.17"
resolved "https://registry.yarnpkg.com/svg-baker/-/svg-baker-1.2.17.tgz#452ceaa604f784e4b864740e4b6b3faf6458d016"
dependencies:
Expand All @@ -7956,6 +7956,24 @@ svg-baker@^1.2.0, svg-baker@^1.2.17:
query-string "^4.3.2"
traverse "^0.6.6"

svg-baker@^1.3.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/svg-baker/-/svg-baker-1.3.0.tgz#93a454fcf9d39ad0caf72cbfbc700f3815c7fa07"
dependencies:
bluebird "^3.5.0"
clone "^2.1.1"
he "^1.1.1"
image-size "^0.5.1"
loader-utils "^1.1.0"
merge-options "0.0.64"
micromatch "3.1.0"
postcss "^5.2.17"
postcss-prefix-selector "^1.6.0"
posthtml-rename-id "^1.0"
posthtml-svg-mode "^1.0"
query-string "^4.3.2"
traverse "^0.6.6"

svgo-loader@^1.2.1:
version "1.2.1"
resolved "https://registry.yarnpkg.com/svgo-loader/-/svgo-loader-1.2.1.tgz#e255cdebf56753ff83bd28d1d7a20762c0df5130"
Expand Down

0 comments on commit 4bbccab

Please sign in to comment.