-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Prevent Original SVG Attributes From Being Removed. #304
Comments
Could you please provide an example of your svg file? |
Sure!
|
Okay, I can add needed attributes to white list, could you provide them? |
Agreed on the width and height. aria-* and role should be good right now. Thanks! |
kisenka
added a commit
to JetBrains/svg-mixer
that referenced
this issue
Sep 19, 2018
@smurrayatwork fixed in svg-sprite-loader@4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature, report a bug or ask a question?
What is the current behavior?
Currently, when the sprite is generated, it strips off any existing attributes (things like aria-hidden, role, width, height, etc) from the SVG files that are being pulled into the sprite.
What is the expected behavior?
It'd be nice if it were possible to prevent this somehow. If it is already possible, I'd love an example replied to this issue (please and thank you)!
If this is a feature request, what is motivation or use case for changing the behavior?
The motivation here is that I'm trying to use this with React to create an Icon component that pulls SVG files from a directory. These SVG files already have all the attributes they could need. Since they're being stripped away, I have to provide props in my component to add back something that already exists.
Please tell us about your environment:
The text was updated successfully, but these errors were encountered: