Visual mode

[gchp]

Again, just another question.

In the normal mode file, there is the following:

        case termbox.KeyCtrlV:
            // TODO: Start visual selection
            return

Just want to get some clarification on this before starting work on it. Should CtrlV start regular visual selection? My impression would be that pressing v should start it, without the need for the control key.

[gchp]

In vim CtrlV starts rectangular selection, if I'm not mistaken

[kisielk]

Right on both counts. I think that case was just already in the switch so I added a comment as to what it should eventually do.

[gchp]

Cool, just wanted to double check, thanks!

If there's anything more pressing/important that you'd like worked on by way, just let me know. I'm really enjoying working on this project, so I'll work on whatever is most helpful for you guys.

[kisielk]

Nothing in particular. We really appreciate your contributions, so just keep doing what you're doing. If you have anything you're not sure about or want to address some higher-level things just file an issue to discuss it 👍

[gchp]

Just to note, there is an issue with clearing the selection when exiting visual mode. To fix this, we need to trigger a redraw inside the visualMode.Exit() method. This will need to wait until the redraw issue has been solved. Just wanted to record it here so it didn't get lost.

[kisielk]

I fixed it in 6e45cfd, left a comment there.