Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistant pointer use and mode exports #41

Open
yarbelk opened this issue Jul 1, 2014 · 2 comments
Open

Inconsistant pointer use and mode exports #41

yarbelk opened this issue Jul 1, 2014 · 2 comments

Comments

@yarbelk
Copy link

yarbelk commented Jul 1, 2014

Normal mode stuff is (m *normalMode)
Insert mode stuff is (m insertMode)
Window mode stuff is (m WindowMode)

etc
@yarbelk yarbelk changed the title Inconsistant pointer use Inconsistant pointer use and mode exports Jul 1, 2014
@yarbelk
Copy link
Author

yarbelk commented Jul 1, 2014

This is causing lots of issues for me in https://github.com/yarbelk/vigo/tree/feature/EditorMode
where i'm getting a whole lot of WindowMode does not implement editor.Mode (Enter method has a pointer receiver)

input appreciated.

@yarbelk
Copy link
Author

yarbelk commented Jul 2, 2014

fixed by pull request #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yarbelk