Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is Enter? #47

Open
yarbelk opened this issue Jul 4, 2014 · 1 comment
Open

What is Enter? #47

yarbelk opened this issue Jul 4, 2014 · 1 comment

Comments

@yarbelk
Copy link

yarbelk commented Jul 4, 2014

So, we have a method Enter on all our Modes - but it is only implemented once and it doesn't seem idomatic - (but rather quite literal: what happens when you press Enter). I figure it should be more general -> What happens when you enter the mode.

Where should we go from here?

@kisielk
Copy link
Owner

kisielk commented Jul 4, 2014

Enter is not what happens when you press the enter key, it's when the editor switches to that mode. Modes can be created without actually being activated on the editor. Probably a lot of code that's in some of the mode constructors should be moved to the Enter method.

Note that a lot of the architecture, particularly around modes, is from the original godit codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants