You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, we have a method Enter on all our Modes - but it is only implemented once and it doesn't seem idomatic - (but rather quite literal: what happens when you press Enter). I figure it should be more general -> What happens when you enter the mode.
Where should we go from here?
The text was updated successfully, but these errors were encountered:
Enter is not what happens when you press the enter key, it's when the editor switches to that mode. Modes can be created without actually being activated on the editor. Probably a lot of code that's in some of the mode constructors should be moved to the Enter method.
Note that a lot of the architecture, particularly around modes, is from the original godit codebase.
So, we have a method Enter on all our Modes - but it is only implemented once and it doesn't seem idomatic - (but rather quite literal: what happens when you press Enter). I figure it should be more general -> What happens when you enter the mode.
Where should we go from here?
The text was updated successfully, but these errors were encountered: