-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anywhere flag to _find methods. #33
Conversation
- Address Issue #32 Enveloped signature: Signature-placeholder not found when not direct child of root
- Set anywhere=True when searching for Signature. - Replace ':' with '.' in XPATH query to find Signature tag.
Can you add a test case that exercises this functionality? |
This expansion highlights the need to better guide users of this package to use best practices (make sure they pass a specific X.509 cert that they expect the signature to use, or another way to ascertain that the signature is authentic; and only trust data returned by Since that concern is not really exacerbated by this change, and you seem to be in a rush, I can merge and release this now as long as you promise to add a test case in a later PR. |
I respect your desire to have a test case before merging and will add one On Wed, Nov 4, 2015 at 10:17 AM Andrey Kislyuk notifications@github.com
|
Merging now, will add a test case and release later today. |
Add anywhere flag to _find methods.
Thanks Andrey. -Jerry On Sun, Nov 8, 2015 at 9:13 AM Andrey Kislyuk notifications@github.com
|
Released in v0.4.5. Please test. |
direct child of root