Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed enum34 dependency and moved requirements to setup.py #37

Merged
merged 3 commits into from
Nov 28, 2015

Conversation

agronholm
Copy link
Contributor

I tried my best to fix the Makefile too but it's still broken (Python 3 tests are not using a virtualenv for instance). Consider using tox instead.

kislyuk added a commit that referenced this pull request Nov 28, 2015
Fixed enum34 dependency and moved requirements to setup.py
@kislyuk kislyuk merged commit aef6aa8 into XML-Security:master Nov 28, 2015
@kislyuk
Copy link
Member

kislyuk commented Nov 28, 2015

Thanks! This looks good.

@agronholm
Copy link
Contributor Author

Would you mind cutting a new patch release? I'll be needing it to install a project of mine. Thanks!

@kislyuk
Copy link
Member

kislyuk commented Nov 28, 2015

Sure thing. Released in v0.4.6, please test.

@agronholm
Copy link
Contributor Author

Seems to install fine. Thank you.
Another question: is there a specific reason why it requires an older version of cryptography? Not judging, just wondering.

@kislyuk
Copy link
Member

kislyuk commented Nov 28, 2015

There is no specific reason. I just got into the habit of pinning major version ranges on my dependencies - at work we have been bitten by dependency drift enough times that we always pin them down completely and pip freeze the tree - but cryptography evolves fast enough that this approach may not work. If you run into an issue regarding this, I'm open to removing the upper bound.

@agronholm
Copy link
Contributor Author

Thank you for the answer. I suspected this was the reason. FWIW, all the tests did pass when used with latest versions of all the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants