Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: missing dependency #300

Closed
git-bruh opened this issue Apr 16, 2021 · 2 comments
Closed

libgit2: missing dependency #300

git-bruh opened this issue Apr 16, 2021 · 2 comments

Comments

@git-bruh
Copy link
Member

@mmatongo libgit2 seems to be missing a dependency on cmake. Also nothing actually builds againstlibgit2 (which is only packaged as a static library) due to undefined references symbols provided by zlib, pthread etc. So -lz -lpthread -lcrypto -lssl need to be passed manually (There's nothing in the pkgconfig file either). It works fine without intervention if there's a shared lib available, so maybe that should be enabled aswell.

@mmatongo
Copy link

I'll fix the dependency.

Dylan mentioned that nothing builds against libgit2 when I first made the pull for it and the conclusion of that discussion I think was that it was better to have it in the repos and not need it than to need it and not have it.

At the time I was using stagit heavily so it benefited me to have it in the community repos so I didn't have to think too much about it should I reinstall kiss or anything.

@dilyn-corner
Copy link
Member

Closed by #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants