Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Problem installing new packages #279

Closed
1 task done
TAAPArthur opened this issue Oct 5, 2021 · 6 comments
Closed
1 task done

Problem installing new packages #279

TAAPArthur opened this issue Oct 5, 2021 · 6 comments
Labels
bug Something isn't working can't reproduce

Comments

@TAAPArthur
Copy link
Contributor

  • Does this issue occur in master?

Description

Cannot install new package.

Assuming the package is already built but not yet installed, kiss i dash fails. The issue isn't specific to dash; created a simple pkg that just touched "$1/foo" and ran into the same issue. However if the package is already installed, the issue doesn't occur.

Just to make sure I was in a clean env, I set KISS_ROOT=/tmp/fakeroot and created the dir. I know I was talking about this in #278, but I checked-out out master directly and didn't use that pending change.

Error message

/usr/bin/kiss: line 164: cd: /tmp/fakeroot/var/db/kiss/installed/dash: No such file or directory

From this it makes since why installed packages are fine since /var/db/kiss/installed would exists then.

Verbose log

log.txt

(PS may want to change the issue template to log.txt since github doesn't like extension-less files)

For the most part I'm using sbase/ubase instead of busybox. I imagine that I'm doing something unpopular since no one else seems to be having this issue

@dylanaraps dylanaraps added bug Something isn't working can't reproduce labels Oct 5, 2021
@dylanaraps
Copy link
Member

Does /var/db/kiss/installed/dash exist inside the cached tarball?

@dylanaraps
Copy link
Member

dylanaraps commented Oct 5, 2021

Also, it is failing to do cd "$OLDPWD" in resolve_path. This means the initial cd to this directory works but a later cd back to it does not.

@dylanaraps
Copy link
Member

Please try the latest commit. I believe the issue is that the OLDPWD is incorrect when the cd fails breaking the whole purpose
of its use.

@dylanaraps
Copy link
Member

These values should (in theory) match.

  + cd /home/arthur/Forks/kiss                   # FIRST OLDPWD                                                                               
  + cd /tmp/fakeroot/var/db/kiss/installed/dash  # SECOND OLDPWD                                   

@TAAPArthur
Copy link
Contributor Author

Yup that resolves my problem. Thanks

@TAAPArthur
Copy link
Contributor Author

Also glad that old code where we manually changed PWD got removed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working can't reproduce
Development

No branches or pull requests

2 participants