Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report filenames start with -1 #52

Closed
martinburchell opened this issue Apr 12, 2022 · 3 comments
Closed

Report filenames start with -1 #52

martinburchell opened this issue Apr 12, 2022 · 3 comments

Comments

@martinburchell
Copy link

Describe the bug

The reports that get stored in the directory indicated by the --report_dir argument have filenames prefixed with the current_index on the model. current_index seems to start with -1 (a feature of kittyfuzzer?) so the first report is -1-something, the next 0-something and then 1-something. It would make more sense to me for the reports to begin with either 1 or 0. In addition, zero padding the filenames would make sorting by name consistent with the order in which the reports were created.

Related API definition

I assume any, but here's the one I was using

api_schema.yaml.txt

Software environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Python version: 3.8
  • APIFuzzer Version: Latest from GitHub
KissPeter added a commit that referenced this issue Apr 12, 2022
@KissPeter
Copy link
Owner

Hi,

Can you check https://github.com/KissPeter/APIFuzzer/tree/report_filename_improvement ?
Any PR is welcome
Péter

@martinburchell
Copy link
Author

Hi,

Can you check https://github.com/KissPeter/APIFuzzer/tree/report_filename_improvement ? Any PR is welcome Péter

Yes that looks good. I wasn't sure if current_index should start at -1 but that's down to kittyfuzzer.

@PeterKiss-Sophos
Copy link
Contributor

Yes it is Kitty stuff.
I'm closing this ticket and this change will be in the next release. In the meantime you can get in from master

KissPeter added a commit that referenced this issue Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants