Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default npoints for do.lisomap #2

Closed
ugroempi opened this issue Feb 15, 2018 · 1 comment
Closed

Default npoints for do.lisomap #2

ugroempi opened this issue Feb 15, 2018 · 1 comment

Comments

@ugroempi
Copy link

Thank you for providing Rdimtools!
The default npoints for do.lisomap causes trouble, if the number of rows is not a multiple of 5. It would be good to include rounding, so that the default is always an integer, e.g. max(round(nrow(X)/5), ndim + 1)

Best, Ulrike
@kisungyou
Copy link
Owner

kisungyou commented Mar 4, 2018 •
edited
Loading

Hi @ugroempi ,

For LMDS and LISOMAP, they are well represented. Instead of controlling the input option, I took another step to set it during preprocess type. For the versions upcoming, it will have no problem as of your opinion.

Thanks, Kisung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ugroempi @kisungyou