Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: less moving - more references #1

Closed
wants to merge 2 commits into from

Conversation

tim3z
Copy link
Member

@tim3z tim3z commented Nov 14, 2017

Stop taking ownership of graph in the algorithms for querying shortest paths.
Saves memory in test main and hopefully allows a nicer architecture later on.

ToDo:

  • Should probably do some benchmarks that the smart pointers are optimized away properly and don't lead to some unwanted dynamic dispatches...

@tim3z
Copy link
Member Author

tim3z commented Nov 14, 2017

Benchmarking suggests, there is definitely some overhead, though that might be just the extra indirection because of the data now beeing on the heap...

@tim3z tim3z mentioned this pull request Jan 17, 2018
@tim3z
Copy link
Member Author

tim3z commented Jan 17, 2018

replaced by #5

@tim3z tim3z closed this Jan 17, 2018
@tim3z tim3z deleted the less_moving_more_references branch July 23, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants