Dedup v2 #5
Merged
Dedup v2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slight penalty on async servers because usage of Arcs can possibly fixed, if we use and decompose (and then slice) FirstOutGraphs rather than LinkIterGraphs reversed graphs are still duplicated
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a vastly improved version of #1. I learned a lot about rust since the first try, and this one here is much more elegant and much more flexible. Plus it will help a lot for coming changes. It uses some neat tricks from rusts awesome type system. Including genericness over owned and shared data, associated types and higher kinded trait bounds. Once rust-lang/rfcs#2071 and rust-lang/rfcs#1598 are implemented the code can be cleaned up a little further.