fix: data race on count pending Falco events (#112)

* test: add sleep on TestNewWithFalcoSidekickURL Signed-off-by: Dwi Siswanto <me@dw1.io> * fix: data race on count pending Falco events Signed-off-by: Dwi Siswanto <me@dw1.io> --------- Signed-off-by: Dwi Siswanto <me@dw1.io>
teler-sh · Oct 19, 2023 · a39d234 · a39d234
1 parent f8dbfbd
commit a39d234
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/falcosidekick.go b/falcosidekick.go
@@ -61,12 +61,18 @@ func (t *Teler) checkFalcoEvents() {
 
 	// Check for pending Falco events every 5 seconds.
 	for range ticker.C {
+		// Lock the FalcoSidekick event
+		t.falcoSidekick.sl.Lock()
+
 		// Get the count of pending Falco events.
 		c := len(t.falcoSidekick.events)
 		if c > 0 {
 			// Send pending Falco events to FalcoSidekick.
 			t.sendFalcoEvents()
 		}
+
+		// Unlock the FalcoSidekick event
+		t.falcoSidekick.sl.Unlock()
 	}
 }
 

diff --git a/teler_test.go b/teler_test.go
@@ -11,6 +11,7 @@ import (
 	"os"
 	"strings"
 	"testing"
+	"time"
 
 	"net/http"
 	"net/http/httptest"
@@ -286,6 +287,8 @@ func TestNewWithFalcoSidekickURL(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+
+	time.Sleep(5 * time.Second)
 }
 
 func TestNewWithVerbose(t *testing.T) {