Division by zero crash when window is too small

[ieeemma]

When the window becomes smaller than the inited screen size, pyxel fails with

pyo3_runtime.PanicException: attempt to divide by zero

This happens due to screen_scale:

pyxel/lib/engine/src/sdl2.rs

Lines 395 to 399 in 0784e5f

	let (window_width, window_height) = self.sdl_canvas.window().size();
	let screen_scale = min(
	window_width / self.screen_width,
	window_height / self.screen_height,
	);

Here, screen_scale can be 0 when there is not enough window space vertically or horizontally.

This then causes the division by zero here:

pyxel/lib/engine/src/sdl2.rs

Lines 413 to 414 in 0784e5f

	mouse_x = (mouse_x - window_x - screen_x as i32) / screen_scale as i32;
	mouse_y = (mouse_y - window_y - screen_y as i32) / screen_scale as i32;

If its relevant, I'm on Linux, though I doubt this is platform specific.

Ideally when there isnt enough space, the game view inside the window would shrink to fit the window size.

[kitao]

Thank you for the report.

I expected this issue was prevented by this code:

        sdl_canvas
            .window_mut()
            .set_minimum_size(width, height)
            .unwrap();    

So does it mean there's some environment that ignores minimum size setting?
I continue checking.

[kitao]

In the latest Pyxel, I couldn't reproduce this error on Ubuntu. So let me close.