Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitchenplan updates homebrew, doesn't upgrade #93

Open
Spaceghost opened this issue Aug 4, 2014 · 1 comment
Open

kitchenplan updates homebrew, doesn't upgrade #93

Spaceghost opened this issue Aug 4, 2014 · 1 comment

Comments

@Spaceghost
Copy link

I've been really loving kitchenplan over the last few months. I found it when looking for ways to provision my new macbook.

However, one thing confuses me. Why does kitchenplan update but not upgrade homebrew? I would think it would either do both or neither, since I'm not personally aware of any benefit to updating homebrew other than possibly getting fixes for homebrew itself. Is that why? Would it be unreasonable to want the ability to have kitchenplan upgrade as well?

@roderik
Copy link
Member

roderik commented Sep 2, 2014

We run a brew update to get the latest formula's.
The package provider has a upgrade option and also a install option.

The philosophy is that the easy automated installs do as little as possible to install a new system and upgrading packages might break stuff (recently they upgraded varnish from 3 to 4 and 4 uses a completely different config file).

Everything that is "different" happens usually in recipes where you can do whatever you want (cfr upgrading stuff), you can even use the same code snipped from https://github.com/kitchenplan/chef-homebrewalt/blob/master/recipes/default.rb#L73 in a recipe yet call the upgrade option if you wish to make it as integrated as possible.

In this case, if you want to submit a pull request that adds upgrade to https://github.com/kitchenplan/chef-homebrewalt/blob/master/recipes/default.rb#L73 if a certain attribute is set (so it won't break bc behaviour) i would gladly accept it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants