Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: combine client metrics into server and add options #8

Closed
rogerogers opened this issue Sep 9, 2022 · 2 comments
Closed

Proposal: combine client metrics into server and add options #8

rogerogers opened this issue Sep 9, 2022 · 2 comments
Labels
proposal A proposal need to discuss and will do implementation.

Comments

@rogerogers
Copy link
Collaborator

  • The current code needs to create an http server to monitor the exposed metrics interface every time the middleware is used. If an application uses multiple clients at the same time, many http servers need to be started.
  • add options,e.g: buckets, go runtime metrics...

I've added some options on hertz-contrib/monitor-prometheus
I think we might save the registry the first we created, then reuse this, and register all metrics on it.

@rogerogers
Copy link
Collaborator Author

#9 maybe look like this.

@rogerogers
Copy link
Collaborator Author

  • 现在的情况是每次调用中间件都需要创建一个http server去暴露指标给prometheus,如果一个服务创建了很多client,那么可能需要创建很多metric server。
  • 添加一些选项,比如buckets,运行时指标

@HeyJavaBean HeyJavaBean added the proposal A proposal need to discuss and will do implementation. label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal need to discuss and will do implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants