Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JPlayer #1167

Open
stweil opened this issue Feb 4, 2024 · 4 comments
Open

Replace JPlayer #1167

stweil opened this issue Feb 4, 2024 · 4 comments
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.

Comments

@stweil
Copy link
Member

stweil commented Feb 4, 2024

Description

JPlayer is one of the libraries used by Kitodo.Presentation. It was added to the code base in commit e7a21a4 to get an audio player GUI.

That library was last released ten years ago, a related website still uses Wordpress 3.9, the last commit was seven years ago, issues and pull requests are not answered. So there are a lot of indicators that jPlayer is unmaintained.

I now made a last try here: jplayer/jPlayer#436

If jPlayer remains unmaintained, it should be replaced because unmaintained code is a security risk.
Meanwhile HTML 5 is standard, and using an extra library for an audio player might no longer be needed.

Related Issues

Expected Benefits of this Development

This is a code maintenance task, necessary to eliminate potential risks by unmaintained code.

Estimated Costs and Complexity

Hopefully the costs for this task are low (less than 5 working days).

@stweil stweil added the ⭐ development fund 2024 A candidate for the Kitodo e.V. development fund. label Feb 4, 2024
@sebastian-meyer
Copy link
Member

sebastian-meyer commented Feb 4, 2024

As far as I am aware, @fschoelzel at SLUB Dresden is working on implementing shaka-player for video. Maybe we can use that for audio as well and get rid of jPlayer that way?

@stweil
Copy link
Member Author

stweil commented Feb 4, 2024

Maybe. But perhaps it is sufficient to use simple HTML 5 code for audio. There even exist code generators for audio players. I updated the description above.

@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Mar 11, 2024
@fschoelzel
Copy link
Contributor

After the implementation of the dev-mediaplayer branch (PR: #818), the default audio player is the shaka-player integration, due to common desired features between audio and video files, and also to keep the UI the same. On my current development branch, shaka-player is running on the latest version and is well maintained, but I need to remove the old JPlayer functionality.

@sebastian-meyer
Copy link
Member

sebastian-meyer commented Mar 18, 2024

Votes: 0 (because this doesn't need more funding)

@sebastian-meyer sebastian-meyer removed the ⭐ development fund 2024 A candidate for the Kitodo e.V. development fund. label May 14, 2024
@sebastian-meyer sebastian-meyer changed the title [FUND] Replace JPlayer Replace JPlayer May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

No branches or pull requests

3 participants