Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page View Plugin doesn't work out-of-the-box #304

Closed
sebastian-meyer opened this issue Sep 17, 2018 · 3 comments
Closed

Page View Plugin doesn't work out-of-the-box #304

sebastian-meyer opened this issue Sep 17, 2018 · 3 comments
Assignees
Labels
🐛 bug A non-security related bug. ⛔ invalid A non-reproducable or layer 8 problem.

Comments

@sebastian-meyer
Copy link
Member

Since the third-party extension t3query is no longer compatible with newer versions of TYPO3, we removed the dependency, but failed to find a proper alternative to ensure loading of the jQuery library prior to initializing OpenLayers in the Page View Plugin.
Recent versions of TYPO3 come with their own jQuery library, so we should rely on that. We need to implement it in a way that the Page View Plugin ensures loading of the jQuery library.

@albig
Copy link
Collaborator

albig commented Sep 17, 2018

That's not true. If you include the static template - as you should do, jQuery is included via CDN or from dlf. Current Javascript in Kitodo.Presentation is only working with jQuery 2.x.
The TYPO3 jQuery library is IMHO intended for backend modules only.

@sebastian-meyer
Copy link
Member Author

Thanks for the quick reply! The static template was added, but the Page View Plugin didn't show anything. The Chrome developer console showed Javascript errors hinting at a missing jQuery library.
I'll have another look at it!

@sebastian-meyer sebastian-meyer self-assigned this Mar 15, 2019
@sebastian-meyer sebastian-meyer added the ⛔ invalid A non-reproducable or layer 8 problem. label Mar 17, 2019
@sebastian-meyer
Copy link
Member Author

I can't reproduce this issue. Even with a blank minimal installation of TYPO3 8.7 the plugin works out-of-the-box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug. ⛔ invalid A non-reproducable or layer 8 problem.
Projects
None yet
Development

No branches or pull requests

2 participants