-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💅🏻 Changed add event button's style #205
💅🏻 Changed add event button's style #205
Conversation
@@ -22,6 +23,8 @@ const FlexRow = styled.div` | |||
display: flex; | |||
`; | |||
|
|||
const AddEventButton = FilterMenuLink.extend``; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semantically it should be a button, so you can use withComponent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@@ -90,7 +97,7 @@ class EventsFeed extends React.Component { | |||
{['All', 'Upcoming', 'Past'].map(filter => ( | |||
<FilterTab key={filter} to={`/events?show=${filter.toLowerCase()}`} data-active={show === filter.toLowerCase()}>{filter}</FilterTab> | |||
))} | |||
<button className="e2e-add-event-button" onClick={onCreateEvent}>Add event</button> | |||
<AddEventButton to="#" className="e2e-add-event-button" onClick={onCreateEvent}>+ Add event</AddEventButton> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to
anymore :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real talk! Fixed.
Created an abstract component "FilterMenuLink" that has two descendants: FilterTab and AddEventButton.
#197