Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruler iframe demo video is removed by the sanitizer. #438

Open
AbdulrhmnGhanem opened this issue Sep 30, 2022 · 2 comments
Open

ruler iframe demo video is removed by the sanitizer. #438

AbdulrhmnGhanem opened this issue Sep 30, 2022 · 2 comments
Labels
import-v1-projects

Comments

@AbdulrhmnGhanem
Copy link
Member

v1 v2 GitHub
image image image
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this issue Sep 30, 2022
Closed
@kasbah
Copy link
Member

kasbah commented Sep 30, 2022

I think it's fine to go with the more cautious sanitization for now.

@kasbah
Copy link
Member

kasbah commented Oct 3, 2022

Let's leave it open for a future improvement. We should at least show the removed iframe like github does?

@kasbah kasbah reopened this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
import-v1-projects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kasbah @AbdulrhmnGhanem