Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional vendors and allow filtering #7

Closed
kasbah opened this issue Apr 2, 2019 · 10 comments
Closed

Enable additional vendors and allow filtering #7

kasbah opened this issue Apr 2, 2019 · 10 comments

Comments

@kasbah
Copy link
Member

kasbah commented Apr 2, 2019

As mentioned in hildogjr/KiCost#346. We should be able to support all vendors that octopart indexes (and then some, when we get to it).

@hildogjr
Copy link

hildogjr commented Jun 2, 2019

Sure, this will remove some unnecessary bottle neck due requested and not used data.

@kasbah
Copy link
Member Author

kasbah commented Oct 23, 2019

This is implemented as of ba43354. Filtering is done using a from argument with offers. E.g:

{
  search(term: "resistor 1k 0603") {
    offers(from: ["Digikey", "Mouser"]) {
      sku {
        vendor
        part
      }
      prices {
        USD
      }
    }
  }
}

@kasbah kasbah closed this as completed Oct 23, 2019
@hildogjr
Copy link

Nice, I am making here to include this into the KiCost attempt. Will this also work with math API, correct?

@kasbah
Copy link
Member Author

kasbah commented Oct 23, 2019

What's the math API? Just to be clearer here is an example with previously disabled vendors. Everything except 'Digikey' and 'RS' uses the same names as the Octopart API.

{
  search(term: "resistor 1k 0603") {
    offers(from: ["TME", "LCSC"]) {
      sku {
        vendor
      }
      prices {
        USD
      }
    }
  }
}

@hildogjr
Copy link

hildogjr commented Oct 23, 2019

How you can get from LCSC PCB? I planned to include this in KiCost.
What is your full distributor supported list? (Basically all Octopart?)

@kasbah
Copy link
Member Author

kasbah commented Oct 23, 2019

Yep, all of Octopart now which includes some info from LCSC. I haven't done anything special yet. Just passing the info on for now.

@hildogjr
Copy link

Is the https://dev-partinfo.kitspace.org/ offline? I was trying to test and integrate the new feature into KiCost.

@kasbah
Copy link
Member Author

kasbah commented Oct 25, 2019

Oops, I messed up the server/domain transfer. Should be up again soon.

@hildogjr
Copy link

Returned
I think now your Digikey and RS are given me no offers.

@kasbah
Copy link
Member Author

kasbah commented Oct 26, 2019

Thanks for reporting, fixed it with 9d14cf8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants