Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

race-condition in isIdUsed #11

Closed
kitsudaiki opened this issue Oct 6, 2019 · 2 comments
Closed

race-condition in isIdUsed #11

kitsudaiki opened this issue Oct 6, 2019 · 2 comments
Assignees
Labels
Bug Bug-reports

Comments

@kitsudaiki
Copy link
Owner

the method isIdUsed in the session-handler has a race-condition. IDs of sessions in the pending list, are ignored and even, if they are not ignored, there is a little time-window, where IDs are used, but in no list.

This race-condition must be avoided, to avoid double usage of IDs.

The current ignorance of the pending IDs is the reasion, why the test actually works. More correctly, only two differenc instances of the test-binary should be able to create a session.

@kitsudaiki kitsudaiki added the Bug Bug-reports label Oct 6, 2019
@kitsudaiki
Copy link
Owner Author

will change the init process so that both sides of a session can have different ids. Instead of this both side have to save the id of the other side. This makes many things easier.

@kitsudaiki
Copy link
Owner Author

will be resolved with #15

@kitsudaiki kitsudaiki self-assigned this Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Bug-reports
Projects
None yet
Development

No branches or pull requests

1 participant