New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npmInstallInDir and linkDepedendenciesForPackage happen in wrong order #59
Comments
Interesting. it looks like the problem I had with local, non-published files was caused by naming an explicit version instead of including a "^" in the dependency's version specifier. I think I've fixed the issue that I had, but I'll leave this issue open until a maintainer takes a look because the current task ordering still seems problematic to me. |
The reason this was done previously is because npm was installing over the "linked" packages. I wasn't able to figure out why so I reversed the order. I can see how this order is a problem for linking deps before they are published. I'll have to look into it more. |
Fixed in 2.0.0-beta.4 |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It looks like 4ecfff5 reversed the order of
npmInstallInDir
andlinkDependenciesForPackage
occur, solerna bootstrap
fails if the local packages have not previously been published to npm.I'm happy to submit a PR to fix, but given how small that commit is, it seems like this was done intentionally.
The text was updated successfully, but these errors were encountered: