Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npmInstallInDir and linkDepedendenciesForPackage happen in wrong order #59

Closed
ianwremmel opened this issue Feb 15, 2016 · 4 comments
Closed

Comments

@ianwremmel
Copy link
Contributor

It looks like 4ecfff5 reversed the order of npmInstallInDir and linkDependenciesForPackage occur, so lerna bootstrap fails if the local packages have not previously been published to npm.

I'm happy to submit a PR to fix, but given how small that commit is, it seems like this was done intentionally.

@ianwremmel
Copy link
Contributor Author

Interesting. it looks like the problem I had with local, non-published files was caused by naming an explicit version instead of including a "^" in the dependency's version specifier. I think I've fixed the issue that I had, but I'll leave this issue open until a maintainer takes a look because the current task ordering still seems problematic to me.

@jamiebuilds
Copy link
Contributor

The reason this was done previously is because npm was installing over the "linked" packages. I wasn't able to figure out why so I reversed the order.

I can see how this order is a problem for linking deps before they are published. I'll have to look into it more.

@jamiebuilds
Copy link
Contributor

Fixed in 2.0.0-beta.4

@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants