Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive common utils? #11

Closed
Kcko opened this issue Dec 2, 2015 · 7 comments
Closed

Responsive common utils? #11

Kcko opened this issue Dec 2, 2015 · 7 comments

Comments

@Kcko
Copy link

Kcko commented Dec 2, 2015

Where should i place common simple responsive rules?
My opinion is 3. 'base/responsive';

@KittyGiraudel
Copy link
Owner

Why do you mean by responsive rules?

@Kcko
Copy link
Author

Kcko commented Dec 2, 2015

I like to have common set of responsive rules

/* Very common responsive rules
---------------------------------------------------------------------------------------------------- */

img 
{
    max-width: 100%;
    height: auto;
}


@media \0screen 
{
    img 
    { 
        width: auto; /*  ie 8 */
    }
}

This file i missing in your awesome skelet.

@KittyGiraudel
Copy link
Owner

Oh. I guess I would put it in base/base.

@Kcko
Copy link
Author

Kcko commented Dec 2, 2015

My opinion is separate file in /base ... ; but thx :)

@Kcko
Copy link
Author

Kcko commented Dec 2, 2015

Hugo, I have one last question.

Whats different between _base.scss and _typography.scss. I think that are equals. Styles for body, H1-H6, commons para etc can be inserted in both.

Can you show me some god example (that i understand distinction).

Thx very much

@KittyGiraudel
Copy link
Owner

In _typography.scss, you will stuff everything related to your typography: font styles for headings, content elements, your modular scale, etc.

In _base.scss, you could have some browser resets, the box-sizing reset, and various rules targeting default elements that are not related to typography.

@Kcko
Copy link
Author

Kcko commented Dec 2, 2015

+1 :-)

S pozdravem

Roman Janko
Frontend Specialist / PHP Developer

gsm: [+420] 777 856 657
email: admin@rjwebdesign.cz mailto:admin@rjwebdesign.cz
icq: 176-031-471
www: rjwebdesign.cz http://rjwebdesign.cz
linkedin: linkedin.com/in/romanjanko
http://www.linkedin.com/in/romanjanko
twitter: twitter.com/RomanJanko https://twitter.com/RomanJanko

Rjwebdesign logo

Dne 2.12.2015 v 14:42 Hugo Giraudel napsal(a):

In |_typography.scss|, you will stuff everything related to your
typography: font styles for headings, content elements, your modular
scale, etc.

In |_base.scss|, you could have some browser resets, the box-sizing
reset, and various rules targeting default elements that are not
related to typography.


Reply to this email directly or view it on GitHub
#11 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants