Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename themes to... #22

Closed
robsonsobral opened this issue Dec 15, 2016 · 6 comments
Closed

Rename themes to... #22

robsonsobral opened this issue Dec 15, 2016 · 6 comments

Comments

@robsonsobral
Copy link
Contributor

I know I already suggested a change on the name of this folder and, exactly because of that, why not name it others?

;-)

@KittyGiraudel
Copy link
Owner

Because others is a dumpster and does not encourage any good practice and proper tidy behaviour regarding file organisation. It’s what you use when you don’t know where to put it, and that’s usually a recipe for disaster in a team on the long run.

@robsonsobral
Copy link
Contributor Author

Good point. Files I already struggled to find a place:

  • _shame.scss
  • _print.scss

@KittyGiraudel
Copy link
Owner

I’d put them in base/.

@robsonsobral
Copy link
Contributor Author

It's fine for _print.scss, but not for _shame.scss, since they're supposed to be the last style of all (where you put that nasty workarounds you don't have time to give much though).


OFF-TOPIC: you and Miriam Suzanne should be awarded with a prize for the most patience people on github).

@KittyGiraudel
Copy link
Owner

It's fine for _print.scss, but not for _shame.scss, since they're supposed to be the last style of all (where you put that nasty workarounds you don't have time to give much though).

Feel free to include _shame.scss at the very end of the main file if necessary. :)

Ping @mirisuzanne for the kind words. :)

@robsonsobral
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants