Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for a simple search page #144

Closed
kostasx opened this issue May 3, 2016 · 11 comments
Closed

Proposal for a simple search page #144

kostasx opened this issue May 3, 2016 · 11 comments

Comments

@kostasx
Copy link
Contributor

kostasx commented May 3, 2016

(Enhancement)
I have created a gh-pages branch and placed a simple search page that uses the JSON data.
Please check it here and let me know If I should create a pull request.
;)

@KittyGiraudel
Copy link
Owner

Wow, that’s awesome, I love it! Would you mind submit a PR? I’ll review the design a tiny bit, add some credits to you and release it! :)

@kostasx
Copy link
Contributor Author

kostasx commented May 4, 2016

Sure. One problem though. Is it possible to create a PR for the gh-pages branch, which is not available on your repo?

@KittyGiraudel
Copy link
Owner

Let me create the branch for you.

@KittyGiraudel
Copy link
Owner

Done.

@KittyGiraudel
Copy link
Owner

I love what you did, can’t wait to release it! :)

@kostasx
Copy link
Contributor Author

kostasx commented May 4, 2016

Thanks. I really like the project.
Just did a PR.

@KittyGiraudel
Copy link
Owner

KittyGiraudel commented May 5, 2016

Seems live: http://hugogiraudel.com/SJSJ/. Thank you so much for your work, I will announce it as soon as I've double checked everything. :)

Still have some path issues.

@kostasx
Copy link
Contributor Author

kostasx commented May 5, 2016

Sure. I see that the entry pages are not working.
I will keep a close eye on your updates.
(I've just found out you'll be talking at DevIt. Have a great time in Thessaloniki!)

@KittyGiraudel
Copy link
Owner

I'll rename the branch right now as I can't investigate any longer. I'd like to buy a domain name but I need to think bout it.

@kostasx
Copy link
Contributor Author

kostasx commented May 5, 2016

Fair enough.

@KittyGiraudel
Copy link
Owner

Closing this, currently in the process of getting jargon.js.org and deploying the whole thing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants