Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug - 1.19.2] Incompatible with "ITLT" (It's the little things) #17

Closed
KuryKat opened this issue Sep 9, 2023 · 8 comments
Closed

[Bug - 1.19.2] Incompatible with "ITLT" (It's the little things) #17

KuryKat opened this issue Sep 9, 2023 · 8 comments
Assignees
Labels
🐛bug Something isn't working

Comments

@KuryKat
Copy link

KuryKat commented Sep 9, 2023

Bug 描述

Unable to launch the game when using ChatImage + It's the Little things because both export the same package...

复现问题的步骤

1. Install Minecraft + Forge 43.2.23
2. Install ChatImage 1.1.6
3. Install ITLT (It's the little things) 2.2.0 
4. Try to Launch the Game
5. Exception caught from launcher (check below for the logs)

日志记录

Exception caught from launcher
java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:58)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)
Caused by: java.lang.module.ResolutionException: Modules itlt and chatimage export package net.sf.image4j.util to module forge
	at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:901)
	at java.base/java.lang.module.Resolver.failTwoSuppliers(Resolver.java:815)
	at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:736)
	at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
	at java.base/java.lang.module.Configuration.<init>(Configuration.java:140)
	at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:494)

Mod版本

ChatImage 1.1.6 - Minecraft 1.19.2

电脑系统|JAVA版本

Windows 10 + JAVA 17

image

image

image

截图

image

备注

Maybe this or this could help?

@kitUIN
Copy link
Owner

kitUIN commented Sep 11, 2023

ITLT that have the same module patch as ChatImage. It's unfixable. You can only delete the mods that have the same module.

@kitUIN kitUIN closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
@kitUIN
Copy link
Owner

kitUIN commented Sep 11, 2023

You can easily fix it by opening the ChatImage jar file and delete the folder net.sf.image4j

@KuryKat
Copy link
Author

KuryKat commented Sep 15, 2023

I can't do such a thing, since I am distributing the mods in my modpack, there's not a way for me to edit the jar and then release it with the modpack, and that could break some licenses even if I could 😅😅

@kitUIN
Copy link
Owner

kitUIN commented Sep 16, 2023

Unfortunately, I haven't found another way to fix the bug yet

@KuryKat
Copy link
Author

KuryKat commented Oct 12, 2023

@kitUIN do you think it could be possible to fix this with JarJar?

https://forge.gemwire.uk/wiki/Jar-in-Jar

@KuryKat
Copy link
Author

KuryKat commented Oct 13, 2023

I managed to fix the issue on ITLT's side, by relocating the package to somewhere else using the shadow plugin, do you think you could do the same on your mod?

I did some PRs here for the other mod, maybe you could take a look, that fixed the issue

@kitUIN
Copy link
Owner

kitUIN commented Oct 15, 2023

you are right🤗
I will fix it

@kitUIN kitUIN reopened this Oct 15, 2023
@kitUIN kitUIN closed this as completed Oct 15, 2023
@KuryKat
Copy link
Author

KuryKat commented Oct 16, 2023

Thank you! ❤🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants