Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] As an interim solution, move the following dependencies into the Phoenix repo: HiRedis, Pcre2, HttpParserHelper, and CurlHelpers. #25

Closed
dfirsht opened this issue Feb 8, 2016 · 3 comments
Milestone

Comments

@dfirsht
Copy link
Contributor

dfirsht commented Feb 8, 2016

Issue by ricardo-olivieri
Friday Jan 08, 2016 at 19:08 GMT
Originally opened as https://github.ibm.com/ibmswift/Phoenix/issues/25


Given that the current version of Package Manager does not support the functionality we need to successfully build the project on linux, in the meantime, we plan to move these dependencies into the same repo as this project for ease of development.

@dfirsht dfirsht added this to the 0.1 milestone Feb 8, 2016
@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by KALLNER
Monday Jan 11, 2016 at 10:10 GMT


Why was this done? Having all of the dependencies in one repository does in fact make development easier, in theory, whether or not one uses the Package Manager.

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by rfdickerson
Monday Jan 11, 2016 at 14:15 GMT


True, Package Manager or not, it really improves the efficiency of our development cycle. We started to realize that each respective module HiRedis, Pcre2, etc still need some changes for the build to work. Previously, we had to check in the changes, add a tag, and push the commit for us to test if those changes worked. The consolidated approach seems to be better, at least for the time being, as we build out each module.

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by ricardo-olivieri
Monday Jan 11, 2016 at 15:57 GMT


This work item is being marked as invalid.

@dfirsht dfirsht closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant