Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get SwiftyJSON to compile on linux (or remove dependency on it) #2

Closed
dfirsht opened this issue Feb 8, 2016 · 4 comments
Closed

Get SwiftyJSON to compile on linux (or remove dependency on it) #2

dfirsht opened this issue Feb 8, 2016 · 4 comments
Assignees
Milestone

Comments

@dfirsht
Copy link
Contributor

dfirsht commented Feb 8, 2016

Issue by ricardo-olivieri
Wednesday Jan 06, 2016 at 22:58 GMT
Originally opened as https://github.ibm.com/ibmswift/Phoenix/issues/2


Some of the Swfit code in the net module depends on the SwiftyJSON library. As of now, we cannot get the SwiftyJSON library to compile.

This issue may have to be revisited. For instance, an alternative to SwiftyJSON is the following library (which is written entirely in Swift): https://github.com/Zewo/JSON. Another alrernative is to simply eliminate any dependencies on 3rd party Swift libraries.

Probably the benefits of using SwiftyJSON are negligible. For instance, when compared to the Gson library, SwiftyJSON does not even provide a quarter of the functionality Gson provides.

@dfirsht dfirsht added this to the 0.3 milestone Feb 8, 2016
@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by dfirsht
Monday Jan 11, 2016 at 20:59 GMT


we removed all json parsing, removing the need for SwiftyJSON or another 3rd pary library

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by KALLNER
Wednesday Jan 13, 2016 at 07:27 GMT


I am porting SwiftJSON to Linux. When I finish the port I will add back all of the JSON parsing in Phoenix.

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by KALLNER
Wednesday Jan 20, 2016 at 17:11 GMT


A reminder:

  1. Two tests are commented out for now in Tests/BaseTests.swift
  2. Several assertions are commented out in Tests/RawRepresentableTests.swift due to lack of bridging
  3. Commented out references to self.measureBlock and autorelasingpool in Tests/PerformanceTests.swift

@dfirsht dfirsht modified the milestones: 0.4, 0.3 Feb 8, 2016
@shmuelk
Copy link
Collaborator

shmuelk commented Feb 9, 2016

The "forked" SwiftyJSON repo now compiles and runs on Linux. On OSX we are using the original one for the time being.

@shmuelk shmuelk closed this as completed Feb 9, 2016
sandmman pushed a commit to sandmman/Kitura that referenced this issue Dec 8, 2017
rolivieri pushed a commit that referenced this issue Jan 9, 2018
* Kitura Evolution #2 & #3

* Minor fix

* Moves query coders to kitura contracts

* Removes tests from linux main

* Appends json content-type to codable response

* Changes send methods to throw

* Updates jazzy docs

* Changes name from query to queryparams

* [ci skip] update package dependencies

* Readds missing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants