Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert regular expression matching from pcre2 to NSRegularExpression #47

Closed
dfirsht opened this issue Feb 8, 2016 · 4 comments
Closed

Convert regular expression matching from pcre2 to NSRegularExpression #47

dfirsht opened this issue Feb 8, 2016 · 4 comments
Assignees
@shmuelk
Labels
enhancement foundation
Milestone
0.5

Comments

@dfirsht
Copy link
Contributor

dfirsht commented Feb 8, 2016

Issue by rfdickerson
Thursday Jan 14, 2016 at 19:17 GMT
Originally opened as https://github.ibm.com/ibmswift/Phoenix/issues/47

This is just to remind us that once Foundation has been finished, we can use NSRegularExpression for native regex matching instead of using an external C library.

Here is the current unimplemented NSRegularExpression
@dfirsht dfirsht added this to the 0.7 milestone Feb 8, 2016
@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by ricardo-olivieri
Monday Jan 18, 2016 at 16:24 GMT

Doing so, will remove the dependency on the helper C code we have in the helper repos. Thus eliminating the need for compiling C code.

@shmuelk
Copy link
Collaborator

shmuelk commented Feb 9, 2016

With the February 3rd drop of the Development stream of Swift, there is now at least a partial implementation of NSRegularExpression.

This would be something useful to do when things stabilize a bit.

@shmuelk shmuelk assigned shmuelk and unassigned rfdickerson Feb 26, 2016
@dfirsht dfirsht modified the milestones: 0.5, Product Backlog Mar 1, 2016
@dfirsht
Copy link
Contributor Author

dfirsht commented Mar 2, 2016

Relavent commit: https://github.com/IBM-Swift/Kitura-router/commit/ab1ad7a8bf72cc5d9dd9cb2680bd92a9743bb339

@dfirsht
Copy link
Contributor Author

dfirsht commented Mar 3, 2016

Validated and working correctly.

@dfirsht dfirsht closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shmuelk shmuelk

Labels
enhancement foundation
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
3 participants
@rfdickerson @dfirsht @shmuelk