Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release of django-allauth 0.58 breaks templates #79

Open
brianhelba opened this issue May 9, 2024 · 2 comments · May be fixed by #85
Open

Release of django-allauth 0.58 breaks templates #79

brianhelba opened this issue May 9, 2024 · 2 comments · May be fixed by #85

Comments

@brianhelba
Copy link
Contributor

django-allauth 0.58 includes the following change:

Refactored the built-in templates, with the goal of being able to adjust the look and feel of the whole project by only overriding a few core templates. This approach allows you to achieve visual results fast, but is of course more limited compared to styling all templates yourself. If your project provided its own templates then this change will not affect anything, but if you rely on (some of) the built-in templates your project may be affected.

The changes were made primarily in pennersr/django-allauth#3466 .

At a minimum, the styled pages of django-auth-style should be reviewed, to see if anything is broken.

Additionally, we should investigate whether it's possible to change this library to apply styles only to the core templates of django-allauth, which may reduce the surface area and maintenance burden of this library significantly.
@brianhelba
Copy link
Contributor Author

We should consider this library to be soft-broken by django-allauth >= 0.58.

However, I'm not sure whether it makes sense to pin the requirements accordingly, since this will force downstreams to adopt an older version of an important library, just to prevent some style bugs.

@brianhelba
Copy link
Contributor Author

One breaking change is that the link to the account_reset_password page within login.html was removed and instead added as help_text on the password field of LoginForm.

This causes the link to now display twice, with django-auth-style.

The easiest fix is to remove corresponding HTML from django-auth-style, to match the upstream version. However, this will require that django-auth-style depend on django-allauth >= 0.58, which might introduce other breakages.

@brianhelba brianhelba mentioned this issue May 9, 2024
Merged
@brianhelba brianhelba closed this as completed by moving to Needs review in Resonant road map & backlog Jul 2, 2024
@brianhelba brianhelba linked a pull request Jul 2, 2024 that will close this issue
Draft
@brianhelba brianhelba reopened this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Resonant road map & backlog
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new elements framework to style Django-Allauth kitware-resonant/django-auth-style
1 participant
@brianhelba