Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KWIVER consumers can't build against an install. Variant.hpp publicly exposed #1521

Closed
dstoup opened this issue Feb 28, 2022 · 2 comments
Closed
Assignees

Comments

@dstoup
Copy link
Collaborator

dstoup commented Feb 28, 2022

Back in November a PR landed that has variant.hpp included in the header, visit.h. Visit.h is installed but variant.hpp is not which prevents any external build from succeeding against an installed KWIVER. We either need to remove variant.hpp from 'internal' or fix visit so variant.hpp is kept internal.

@daniel-riehm
Copy link
Collaborator

I would opt towards making it public - it's a third-party implementation of C++17 standard library file <variant>, and we wouldn't feel strong reasons to not include <variant> in our publicly-included files.

(Of course, the real solution here is to upgrade to C++17.)

@daniel-riehm
Copy link
Collaborator

Tentatively closing as issue seems to have been resolved by #1522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants