You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Back in November a PR landed that has variant.hpp included in the header, visit.h. Visit.h is installed but variant.hpp is not which prevents any external build from succeeding against an installed KWIVER. We either need to remove variant.hpp from 'internal' or fix visit so variant.hpp is kept internal.
The text was updated successfully, but these errors were encountered:
I would opt towards making it public - it's a third-party implementation of C++17 standard library file <variant>, and we wouldn't feel strong reasons to not include <variant> in our publicly-included files.
(Of course, the real solution here is to upgrade to C++17.)
Back in November a PR landed that has variant.hpp included in the header, visit.h. Visit.h is installed but variant.hpp is not which prevents any external build from succeeding against an installed KWIVER. We either need to remove variant.hpp from 'internal' or fix visit so variant.hpp is kept internal.
The text was updated successfully, but these errors were encountered: