Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger plugins have inconsistent linkage on Windows #167

Closed
mleotta opened this issue Jun 27, 2017 · 0 comments
Closed

Logger plugins have inconsistent linkage on Windows #167

mleotta opened this issue Jun 27, 2017 · 0 comments
Assignees
Labels

Comments

@mleotta
Copy link
Member

mleotta commented Jun 27, 2017

The vital logger plugins do not properly build on Windows because of inconsistent DLL linkage. It appears each plugin builds a copy of some of the same source files. This is problematic because they include vital_logger_export.h and use the VITAL_LOGGER_EXPORT macro each time instead of a different include/macro for each plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants