fix(lint): Fix easy lint errors

Disable some which we do not have resources to fix atm.
Kitware · May 13, 2019 · 94a41a3 · 94a41a3
1 parent 3811668
commit 94a41a3
Show file tree

Hide file tree

Showing 15 changed files with 41 additions and 13 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -39,6 +39,16 @@ module.exports = {
     'no-nested-ternary': 0,
     'react/forbid-prop-types': 0,
     'react/no-array-index-key': 0,
+
+    // When updating to kw-web-suite 8.0.0, we have more lint issues
+    // and no time to fix
+    'react/destructuring-assignment': 0,
+    'react/no-access-state-in-setstate': 0,
+    'react/jsx-one-expression-per-line': 0, // creates a conflict with prettier
+    'jsx-a11y/label-has-associated-control': 0,
+    'no-else-return': 0,
+    'import/no-cycle': 0,
+    'react/jsx-wrap-multilines': 0,
   },
   plugins: [
     'prettier'

diff --git a/src/React/CollapsibleControls/FloatImageControl/index.js b/src/React/CollapsibleControls/FloatImageControl/index.js
@@ -89,11 +89,9 @@ export default class FloatImageControl extends React.Component {
     return (
       <div className={style.container}>
         <CollapsibleWidget title="Scene">
-          {floatImageModel
-            .getLayers()
-            .map((item, idx) => (
-              <LayerItem key={idx} item={item} model={floatImageModel} />
-            ))}
+          {floatImageModel.getLayers().map((item, idx) => (
+            <LayerItem key={idx} item={item} model={floatImageModel} />
+          ))}
           <div className={style.item}>
             <div className={style.label}>Light</div>
             <div className={style.actions}>

diff --git a/src/React/Properties/CollapsiblePropertyGroup/index.js b/src/React/Properties/CollapsiblePropertyGroup/index.js
@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import style from 'PVWStyle/ReactProperties/CollapsiblePropertyGroup.mcss';
-import factory from '../../Properties/PropertyFactory';
+import factory from '../PropertyFactory';
 
 export default function render(props) {
   const isCollapsed = !props.prop.data.value[0];

diff --git a/src/React/Properties/PropertyGroup/index.js b/src/React/Properties/PropertyGroup/index.js
@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import style from 'PVWStyle/ReactProperties/PropertyGroup.mcss';
-import factory from '../../Properties/PropertyFactory';
+import factory from '../PropertyFactory';
 
 export default function render(props) {
   return (

diff --git a/src/React/Renderers/ImageRenderer/index.js b/src/React/Renderers/ImageRenderer/index.js
@@ -611,10 +611,18 @@ export default class ImageRenderer extends React.Component {
               </div>
             </div>
             <div className={style.buttons}>
-              <button className={style.button} onClick={this.toggleDialog}>
+              <button
+                className={style.button}
+                type="button"
+                onClick={this.toggleDialog}
+              >
                 Cancel
               </button>
-              <button className={style.button} onClick={this.updateMetadata}>
+              <button
+                className={style.button}
+                type="button"
+                onClick={this.updateMetadata}
+              >
                 Save
               </button>
             </div>

diff --git a/src/React/Viewers/AbstractViewerMenu/example/index.js b/src/React/Viewers/AbstractViewerMenu/example/index.js
@@ -48,7 +48,7 @@ ReactDOM.render(
         You can put HTML or a React component here, a{' '}
         <em>QueryDataModelWidget</em> for example goes well here.
       </p>,
-      <button key="c" onClick={() => alert('button pressed')}>
+      <button type="button" key="c" onClick={() => alert('button pressed')}>
         Press me
       </button>,
     ]

diff --git a/src/React/Widgets/ButtonSelectorWidget/index.js b/src/React/Widgets/ButtonSelectorWidget/index.js
@@ -32,6 +32,7 @@ export default class ButtonSelectorWidget extends React.Component {
     this.props.list.forEach((item) => {
       list.push(
         <button
+          type="button"
           className={style.button}
           key={item.name}
           name={item.name}

diff --git a/src/React/Widgets/EditableListWidget/index.js b/src/React/Widgets/EditableListWidget/index.js
@@ -173,6 +173,7 @@ class EditableList extends React.PureComponent {
           <div className={style.rowContent}>{cells}</div>
           <div className={style.remove}>
             <button
+              type="button"
               className={style.icon}
               onClick={() => this.props.onDelete(item.key)}
             >
@@ -218,6 +219,7 @@ class EditableList extends React.PureComponent {
         </div>
         <div className={style.row}>
           <button
+            type="button"
             className={style.addButton}
             onClick={() => this.props.onAdd(rows.length)}
           >

diff --git a/src/React/Widgets/InlineToggleButtonWidget/index.js b/src/React/Widgets/InlineToggleButtonWidget/index.js
@@ -63,6 +63,7 @@ export default class InlineToggleButtonWidget extends React.Component {
           if (obj.label) {
             return (
               <button
+                type="button"
                 style={{ lineHeight, fontSize, background }}
                 key={idx}
                 onClick={this.activateButton}

diff --git a/src/React/Widgets/LookupTableWidget/index.js b/src/React/Widgets/LookupTableWidget/index.js
@@ -398,7 +398,7 @@ export default class LookupTableWidget extends React.Component {
               className={style.previousButton}
             />
             <div className={style.label}>
-              {this.state.currentControlPointIndex + 1} /{' '}
+              {this.state.currentControlPointIndex + 1}/{' '}
               {this.props.lookupTable.getNumberOfControlPoints()}
             </div>
             <i onClick={this.nextControlPoint} className={style.nextButton} />

diff --git a/src/React/Widgets/OverlayTitleBar/index.js b/src/React/Widgets/OverlayTitleBar/index.js
@@ -8,6 +8,7 @@ export default function overlayTitleBar(props) {
     <div>
       <span className={style.overlayTitle}>{props.title}</span>
       <button
+        type="button"
         className={style.closeControlBtn}
         name={props.name}
         onClick={props.onClose}

diff --git a/src/React/Widgets/ScatterPlotCameraControl/index.js b/src/React/Widgets/ScatterPlotCameraControl/index.js
@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import style from 'PVWStyle/ReactWidgets/ScatterPlotCameraControl.mcss';
-import InlineToggleButtonWidget from '../../Widgets/InlineToggleButtonWidget';
+import InlineToggleButtonWidget from '../InlineToggleButtonWidget';
 
 const SELECTED_COLOR = '#cdcdcd';
 const DEFAULT_COLOR = '#fff';

diff --git a/src/React/Widgets/SelectionEditorWidget/range/index.js b/src/React/Widgets/SelectionEditorWidget/range/index.js
@@ -103,12 +103,13 @@ render.propTypes = {
   selection: PropTypes.object,
   // ranges: PropTypes.object,
   onChange: PropTypes.func,
-  // getLegend: PropTypes.func,
+  getLegend: PropTypes.func,
   className: PropTypes.string,
 };
 
 render.defaultProps = {
   selection: undefined,
   className: undefined,
   onChange: undefined,
+  getLegend: undefined,
 };
diff --git a/src/React/Widgets/index.js b/src/React/Widgets/index.js
@@ -13,6 +13,7 @@ import Coordinate2DWidget from './Coordinate2DWidget';
 import CountToolbar from './CountToolbar';
 import DoubleSliderWidget from './DoubleSliderWidget';
 import DropDownWidget from './DropDownWidget';
+import EditableListWidget from './EditableListWidget';
 import EqualizerWidget from './EqualizerWidget';
 import FileBrowserWidget from './FileBrowserWidget';
 import GitTreeWidget from './GitTreeWidget';
@@ -55,6 +56,7 @@ export default {
   CountToolbar,
   DoubleSliderWidget,
   DropDownWidget,
+  EditableListWidget,
   EqualizerWidget,
   FileBrowserWidget,
   GitTreeWidget,

diff --git a/src/Rendering/Chart/Histogram2DPlotlyChartBuilder/index.js b/src/Rendering/Chart/Histogram2DPlotlyChartBuilder/index.js
@@ -105,6 +105,7 @@ export default class Histogram2DPlotlyChartBuilder {
   getHistogram() {
     return this.histogram;
   }
+
   getScatter() {
     return this.scatter;
   }
@@ -123,6 +124,7 @@ export default class Histogram2DPlotlyChartBuilder {
     this.histogram = histogram;
     this.buildChart();
   }
+
   setScatter(scatter) {
     // we need a new plot if the axes change, as opposed to just the data.
     if (
@@ -137,6 +139,7 @@ export default class Histogram2DPlotlyChartBuilder {
     this.scatter = scatter;
     this.buildChart();
   }
+
   setPlot(plot) {
     this.chartState.forceNewPlot = true;
     this.plot = plot;
@@ -177,6 +180,7 @@ export default class Histogram2DPlotlyChartBuilder {
   getChartType() {
     return this.chartState.chartType;
   }
+
   getDataType() {
     return chartFactory[this.chartState.chartType].data;
   }