Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] prevent unexpected error in renderPassAll if polyData mapper does not exist #3011

Open
sedghi opened this issue Feb 6, 2024 · 1 comment
Labels
type: bug 🐞 Errors in functionality

Comments

@sedghi
Copy link
Contributor

sedghi commented Feb 6, 2024

Bug description

This is not a bug, but rather an unexpected error.

When there is no polyDataMapper, the renderPassAll goes through polyDataMapper. Since it doesn't have any input, it will throw an error. I'm not sure why it should through an error. Can I create a PR to fix this issue?

CleanShot 2024-02-06 at 10 25 37

CleanShot 2024-02-06 at 10 23 25

Steps to reproduce

I have not tried vtk.js examples, but this is happening in Cornerstone3D.

Detailed Behavior

No response

Expected Behavior

To not through, and only return

Environment

  • vtk.js version: 29.3.0
  • Browsers: Chrome
  • OS: macOS
@sedghi sedghi added the type: bug 🐞 Errors in functionality label Feb 6, 2024
@finetjul
Copy link
Member

finetjul commented Feb 6, 2024

I think the error is here to give a clue to the developer why the rendering is pitch black.
It is questionable why you have a polydatamapper without polydata. Alternatively you could turn off the visibility of the actor to prevent the error.
It could be a warning and not an error though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐞 Errors in functionality
Projects
None yet
Development

No branches or pull requests

2 participants