Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slow operations in overlay() #960

Open
sammlapp opened this issue Feb 23, 2024 · 0 comments
Open

slow operations in overlay() #960

sammlapp opened this issue Feb 23, 2024 · 0 comments
Assignees
Labels
performance speed something up
Milestone

Comments

@sammlapp
Copy link
Collaborator

sammlapp commented Feb 23, 2024

A couple parts of the overla() function in preprocess.actions can be very slow with large overlay_df dataframes:

dropping one index from large df is slow:

warnings.warn(f"Invalid overlay sample: {overlay_path}")
if len(overlay_df) < 1:

.loc[] with multi-index is slow, reset_index for fast integer based index lookup

overlay_sample = AudioSample.from_series(overlay_df.loc[overlay_path])

@sammlapp sammlapp added the performance speed something up label Feb 23, 2024
@sammlapp sammlapp self-assigned this Apr 12, 2024
@sammlapp sammlapp added this to the 0.11.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance speed something up
Projects
None yet
Development

No branches or pull requests

1 participant