Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make private fields public to enable programmatically generating an AST #215

Closed
emschwartz opened this issue May 18, 2022 · 1 comment · Fixed by #216
Closed

Make private fields public to enable programmatically generating an AST #215

emschwartz opened this issue May 18, 2022 · 1 comment · Fixed by #216

Comments

@emschwartz
Copy link
Contributor

emschwartz commented May 18, 2022

First of all, thank you for creating and maintaining this library!

I have a use case where I would like to convert between a custom format and markdown (in both directions) and I would like to use comrak for this.

I have the conversion from markdown working but converting to markdown with comrak isn't fully possible because a number of comrak structs have crate-private fields that make it impossible for other crates to construct a comrak AST.

Would you accept a PR to make the following fields and functions public?

@kivikakk
Copy link
Owner

Hiya! Likewise, thanks for your interest in contributing!

Would you accept a PR to make the following fields and functions public?

I would! Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants