[app] "android.permission" contain an unknown permission

[bob-the-hamster]

When I run buildozer, I get the following error:

james@rhinoctopus:~/src/secrethamster/kivy/bobdirt$ buildozer android debug deploy
# Check configuration tokens
# Ensure build layout
# Check configuration tokens
# Check target configuration tokens
#1 error(s) found in the buildozer.spec
[app] "android.permission" contain an unknown permission 

My buildozer.spec does not modify the default for android.permissions:

# (list) Permissions
#android.permissions = INTERNET

[bob-the-hamster]

Apparently the default value for android.permissions is [""] and that one null value is not found in the list of valid permissions. Here is a patch to fix it:

diff --git a/buildozer/targets/android.py b/buildozer/targets/android.py
index 2a5c496..953449f 100644
--- a/buildozer/targets/android.py
+++ b/buildozer/targets/android.py
@@ -117,7 +117,7 @@ class TargetAndroid(Target):
             permissions = self.buildozer.config.getlist(
                 'app', 'android.permissions', [])
             for permission in permissions:
-                if permission not in available_permissions:
+                if permission and permission not in available_permissions:
                     errors.append(
                         '[app] "android.permission" contain an unknown'
                         ' permission {0}'.format(permission))

[bob-the-hamster]

Actually, here is a better patch that also fixes the typo in the error message:

diff --git a/buildozer/targets/android.py b/buildozer/targets/android.py
index 2a5c496..2ec7bae 100644
--- a/buildozer/targets/android.py
+++ b/buildozer/targets/android.py
@@ -117,9 +117,9 @@ class TargetAndroid(Target):
             permissions = self.buildozer.config.getlist(
                 'app', 'android.permissions', [])
             for permission in permissions:
-                if permission not in available_permissions:
+                if permission and permission not in available_permissions:
                     errors.append(
-                        '[app] "android.permission" contain an unknown'
+                        '[app] "android.permissions" contain an unknown'
                         ' permission {0}'.format(permission))

         super(TargetAndroid, self).check_configuration_tokens(errors)

[tshirtman]

Can you do a pull request of that? :)
(there is an other grammar mistake in the error message by the way :P)

[bob-the-hamster]

I have never done a pull request before, but I am happy to try.

I realized that buildozer still fails later on when android.permissions is left blank

build.py: error: argument --permission: expected one argument
# Command failed: /usr/bin/python2.7 build.py --name 'Bob the Hamster Dirt Dig' --version 0.1 --package com.hamsterrepublic.bobdirt --private /home/james/src/secrethamster/kivy/bobdirt/.buildozer/android/app --sdk 14 --minsdk 8 --permission  --presplash /home/james/src/secrethamster/kivy/bobdirt/.buildozer/android/app/./src/../distimg/presplash.jpg --icon /home/james/src/secrethamster/kivy/bobdirt/.buildozer/android/app/./src/../distimg/icon.png debug

I'll see if I can come up with a more correct patch.

[bob-the-hamster]

I would like to learn to do a pull request, but It seems complicated, so for now, here is a better patch. This does not produce any --permission arguments for blank permissions

diff --git a/buildozer/targets/android.py b/buildozer/targets/android.py
index 2a5c496..3625788 100644
--- a/buildozer/targets/android.py
+++ b/buildozer/targets/android.py
@@ -116,10 +116,11 @@ class TargetAndroid(Target):
         if available_permissions:
             permissions = self.buildozer.config.getlist(
                 'app', 'android.permissions', [])
+            print permissions
             for permission in permissions:
-                if permission not in available_permissions:
+                if permission and permission not in available_permissions:
                     errors.append(
-                        '[app] "android.permission" contain an unknown'
+                        '[app] "android.permissions" contains an unknown'
                         ' permission {0}'.format(permission))

         super(TargetAndroid, self).check_configuration_tokens(errors)
@@ -372,7 +373,8 @@ class TargetAndroid(Target):
         permissions = config.getlist('app',
                 'android.permissions', [])
         for permission in permissions:
-            build_cmd += ' --permission {0}'.format(permission)
+            if permission:
+                build_cmd += ' --permission {0}'.format(permission)

         # add presplash
         presplash = config.getdefault('app', 'presplash.filename', '')

[bob-the-hamster]

Okay. I sent a pull request for a proper fix for this.

[tito]

fixed