Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundManager Track's on_track_stop() recurses til crash #261

Open
jupart opened this issue Oct 9, 2017 · 2 comments
Open

SoundManager Track's on_track_stop() recurses til crash #261

jupart opened this issue Oct 9, 2017 · 2 comments

Comments

@jupart
Copy link

jupart commented Oct 9, 2017

I noticed when setting SoundManager.loop_music = True (which I wish would loop the currently played track, but I can hack that in) that when the track gets stopped, because of .bind(on_stop=on_track_stop), it recurses until we hit a RuntimeError: Maximum recursion depth exceeded. Alternatively, this causes random tracks to get played and stopped randomly if you have more than one track in SoundManager.music_dict.

@jupart
Copy link
Author

jupart commented Oct 9, 2017

Not really a solution, but I created a new function SoundManager.play_track_to_stop() without the if self.current_track is not None check, which I call if self.loop_music is True in self.on_track_stop.

@jupart
Copy link
Author

jupart commented Oct 9, 2017

Probably a separate issue, but you can't .stop() tracks when self.loop_music is True. Another is auto-played after the stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant