Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compile kruft after build. closes #315 #523

Merged
merged 1 commit into from Jul 1, 2020
Merged

Remove compile kruft after build. closes #315 #523

merged 1 commit into from Jul 1, 2020

Conversation

Zen-CODE
Copy link
Member

@Zen-CODE Zen-CODE commented Jun 29, 2020 •
edited

This cleans up compile files in the postbuild step. Tested on basic project, which still builds and compiles successfully with leftover so.o files in the build folder.

@Zen-CODE Zen-CODE requested a review from AndreMiras July 1, 2020 18:00
AndreMiras
AndreMiras approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just I had the feeling I already reviewed it, but I must have brainfarted 😄
Also I don't know what "kruft" means in your commit message

@Zen-CODE
Copy link
Member Author

Zen-CODE commented Jul 1, 2020

Sorry, my bad. that should have been "cruft".

badly designed, unnecessarily complicated, or unwanted code or software.
"this removes all unnecessary cruft from Word documents saved as HTML"

Thanks

@Zen-CODE Zen-CODE merged commit 57e6181 into master Jul 1, 2020
@Zen-CODE Zen-CODE deleted the cleanup branch July 1, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zen-CODE @AndreMiras