Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Plugin Indentifier #26

Closed
mitch7391 opened this issue Jul 29, 2020 · 2 comments
Closed

Incorrect Plugin Indentifier #26

mitch7391 opened this issue Jul 29, 2020 · 2 comments

Comments

@mitch7391
Copy link

Hey @kiwi-cam I noticed this one whilst in debug mode:

image

Not a major one, just thought I would let you know.

@kiwi-cam
Copy link
Owner

This is because the plugin is homebridge-broadklink-rm-pro but it identifies as the parent fork homebridge-broadklink-rm.

Tough one, we could tidy this up but then users could install this fork along with the parent fork - which happens frequently. Then we'd have to change the name we use in the config.json so they don't step on each other. I'm going to put this in the, "one day maybe" list.

@mitch7391
Copy link
Author

Makes sense and all good :) sorry to keep throwing curly ones your way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants