Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextLink_RTL - Icon should aim left #764

Closed
smallram opened this issue Jan 21, 2019 · 1 comment
Closed

TextLink_RTL - Icon should aim left #764

smallram opened this issue Jan 21, 2019 · 1 comment
Assignees
@vepor
Labels
Icons All things related to icons

Comments

@smallram
Copy link

Expected Behavior

The greater-than icon in RTL should be pointing left.

Current Behavior

The greater-than icon in RTL is pointing right:
screenshot-kiwicom github io-2019 01 21-05-22-53

Solution

Probably just change icon={<ChevronRight to icon={<ChevronLeft

Storybook
@smallram smallram added the Bug Something isn't working label Jan 21, 2019
@vepor vepor mentioned this issue Jan 22, 2019
Merged
@vepor vepor self-assigned this Jan 22, 2019
@vepor vepor added Enhancement Icons All things related to icons and removed Bug Something isn't working labels Feb 1, 2019
@vepor
Copy link
Contributor

vepor commented Feb 1, 2019

It's actually not a bug, but some property needs to be added to mirror needed icons on RTL language. It can't be done globally. Proposal is in #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vepor vepor

Labels
Icons All things related to icons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vepor @smallram