OrbitStorybook target

[sjavora]

Previews prefixed with "storybook" that were used in the Storybook view were copied over to the new OrbitStorybook target as new types (akin to StorybookTypography).

This means that Orbit's previews get to stay internal, but can now go out of sync with what is in the storybook. According to @PavelHolec, this isn't a problem since each serves a different purpose/audience.

Closes #323.

[PavelHolec]

For the previews - if it is only few of them, we could just "duplicate" the layout they both share. In future, they might differ on purpose, so they do not need to be necessarily linked.

[sjavora]

Each component has at least one "storybook" preview, but usually there are more. As I wrote above, some are even used for snapshots. I'm ok with moving those to the other target, but not sure I'd want to duplicate them. Wouldn't that be confusing? At least we should then rename those original ones so they don't mention "Storybook" anymore?

[sjavora]

Possibly related, but can we get rid of the explicit static/dynamic targets?

[sjavora]

For the previews - if it is only few of them

It's everyting in this commit. Please let me know how you'd like to proceed.

[PavelHolec]

Possibly related, but can we get rid of the explicit static/dynamic targets?

I thought about that, but potential Xcode11+ iOS13 clients might need it to solve similar issues we had before

[PavelHolec]

Each component has at least one "storybook" preview, but usually there are more. As I wrote above, some are even used for snapshots. I'm ok with moving those to the other target, but not sure I'd want to duplicate them. Wouldn't that be confusing? At least we should then rename those original ones so they don't mention "Storybook" anymore?

Yep, we could remove all traces of "storybook" there. It is possible our needs for snapshot content and storybook content might differ in future, so they do not need to be related.

[sjavora]

Possibly related, but can we get rid of the explicit static/dynamic targets?

I thought about that, but potential Xcode11+ iOS13 clients might need it to solve similar issues we had before

I find this "support" for Xcode11+ / iOS 13 to be... weird. We're not actually checking that everything works with those versions (manually or in CI) and I have a feeling the storybook target will not work for precisely the reason that we have those static/dynamic targets.

[sjavora]

@PavelHolec updated, see new description. One thing I'm still not sure about - do you want to remove the "storybook"-prefixed previews from Orbit, or should they stay for now?

[PavelHolec]

@PavelHolec updated, see new description. One thing I'm still not sure about - do you want to remove the "storybook"-prefixed previews from Orbit, or should they stay for now?

Not necessarily now, but in future, I assume they will be removed/renamed, as the goals of each is supposed to be a bit different (they were reused now for simplicity).

Internal Orbit previews/snapshots:

• aimed more for development
• containing all edge-cases we support (different, multi-line and rich text content)

Storybook content:

• "happy path" state of components, ideally constructed 1:1 to (Figma) designs and matching its (often simple) texts

[PavelHolec]

Possibly related, but can we get rid of the explicit static/dynamic targets?

I thought about that, but potential Xcode11+ iOS13 clients might need it to solve similar issues we had before

I find this "support" for Xcode11+ / iOS 13 to be... weird. We're not actually checking that everything works with those versions (manually or in CI) and I have a feeling the storybook target will not work for precisely the reason that we have those static/dynamic targets.

Agree, let's remove it for now. We can always easily re-add it, if anybody would truly need it

[sjavora]

Possibly related, but can we get rid of the explicit static/dynamic targets?

I thought about that, but potential Xcode11+ iOS13 clients might need it to solve similar issues we had before

I find this "support" for Xcode11+ / iOS 13 to be... weird. We're not actually checking that everything works with those versions (manually or in CI) and I have a feeling the storybook target will not work for precisely the reason that we have those static/dynamic targets.

Agree, let's remove it for now. We can always easily re-add it, if anybody would truly need it

Done separately in #348.