Simplify icon related alignments and paddings #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelHolec
force-pushed
the
317-replace-firsttextbaseline-with-custom-firsttextcenter
branch
4 times, most recently
from
5526747
to
6967c64
Compare
PavelHolec
force-pushed
the
317-replace-firsttextbaseline-with-custom-firsttextcenter
branch
4 times, most recently
from
eb6eb19
to
ad1690d
Compare
PavelHolec
force-pushed
the
317-replace-firsttextbaseline-with-custom-firsttextcenter
branch
from
d133cf7
to
9e7e870
Compare
sjavora
reviewed
Dec 31, 2022
Sources/Orbit/Support/TextConcatenation/TextRepresentable+Concatenation.swift
Outdated
Show resolved
Hide resolved
|
Very nice! Seeing stuff like |
PavelHolec
force-pushed
the
317-replace-firsttextbaseline-with-custom-firsttextcenter
branch
from
9e7e870
to
d3414c0
Compare
Thx, updated with a single line limit and previews. |
sjavora
approved these changes
Jan 2, 2023
PavelHolec
deleted the
317-replace-firsttextbaseline-with-custom-firsttextcenter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317
Text line height is updated to match designs (independently on specific font). This makes it possible to simplify icon alignment, as now the
.topalignment can be used for same-size icon and text.The
firstBaselinealignment for icons is still supported, but the calculation is not as precise, so it is not used in most components, unless needed (BadgeList).Icon alignment is simplified (all vertical guidelines can be used) as the icon size is equal to line height
Component sizes match design sizing independently on used font