Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure react/jsx-no-bind properly #109

Closed
2 tasks done
VaclavSir opened this issue Mar 27, 2018 · 1 comment
Closed
2 tasks done

Configure react/jsx-no-bind properly #109

VaclavSir opened this issue Mar 27, 2018 · 1 comment

Comments

@VaclavSir
Copy link
Contributor

The rule react/jsx-no-bind doesn't warn us when we use an arrow function as a prop (eg. <Button onClick={() => {}} />). It should.


Make sure these boxes are ticked before submitting a new issue:

  • I have checked that this is not a duplicate
  • I have added a label categorizing this under BLKN | Kiwicom | Icons | Global
@vepor
Copy link
Contributor

vepor commented Jan 15, 2020

react/jsx-no-bind doesn't have to configured properly anymore. Since React version with hooks, binding is considered as normal and safe way. Only makes sense for PureComponent or memoized functional component, that we don't use.

@vepor vepor closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants